I have an application where upon registration and payment the user has a new portal created for them. The CreatePortal is a custom module that we have developed. After upgrading from 5.01 to 5.1.2 I am now getting the following exception:

InnerException: Error parsing Portal TemplateFailed to convert parameter value from a String to a Int32. at System.Data.SqlClient.SqlParameter.CoerceValue(Object value, MetaType destinationType)at System.Data.SqlClient.SqlParameter.GetCoercedValue()at System.Data.SqlClient.SqlParameter.Validate(Int32 index, Boolean isCommandProc)at System.Data.SqlClient.SqlCommand.SetUpRPCParameters(_SqlRPC rpc, Int32 startCount, Boolean inSchema, SqlParameterCollection parameters)at System.Data.SqlClient.SqlCommand.BuildRPC(Boolean inSchema, SqlParameterCollection parameters, _SqlRPC& rpc)at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async)at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, DbAsyncResult result)at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method)at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)at Microsoft.ApplicationBlocks.Data.SqlHelper.ExecuteReader(SqlConnection connection, SqlTransaction transaction, CommandType commandType, String commandText, SqlParameter[] commandParameters, SqlConnectionOwnership connectionOwnership)at Microsoft.ApplicationBlocks.Data.SqlHelper.ExecuteReader(String connectionString, CommandType commandType, String commandText, SqlParameter[] commandParameters)at Microsoft.ApplicationBlocks.Data.SqlHelper.ExecuteReader(String connectionString, String spName, Object[] parameterValues)at DotNetNuke.Security.Membership.Data.SqlDataProvider.GetRoleGroupByName(Int32 PortalID, String RoleGroupName)at DotNetNuke.Security.Membership.DNNRoleProvider.GetRoleGroupByName(Int32 PortalID, String RoleGroupName)at DotNetNuke.Entities.Portals.PortalController.CreateRoleGroup(RoleGroupInfo roleGroup)at DotNetNuke.Entities.Portals.PortalController.ParseRoleGroups(XPathNavigator nav, Int32 portalID, Int32 administratorId)at DotNetNuke.Entities.Portals.PortalController.ParseTemplate(Int32 PortalId, String TemplatePath, String TemplateFile, Int32 AdministratorId, PortalTemplateModuleAction mergeTabs, Boolean IsNewPortal)at DotNetNuke.Entities.Portals.PortalController.CreatePortal(String PortalName, UserInfo objAdminUser, String Description, String KeyWords, String TemplatePath, String TemplateFile, String HomeDirectory, String PortalAlias, String ServerPath, String ChildPath, Boolean IsChildPortal)
 

It looks to me to be a mismatch between the sproc and the function - any ideas?

I rebuilt the site in 5.1.2 and I got the following 'Deprecated in 5.1' warning messages related to the module in question

Warning 3 'Public Property Email() As String' is obsolete: 'Deprecated in DNN 5.1'. 

Warning 4 'Public Property Username() As String' is obsolete: 'Deprecated in DNN 5.1'.

Warning 7 'Public Shared Function GetUsers(portalId As Integer, isHydrated As Boolean) As System.Collections.ArrayList' is obsolete: 'Deprecated in DNN 5.1. This function has been replaced by UserController.GetUsers'.

I've changed all of this code, rebuilt and still get the same error.