Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDevelopment and...Development and...Building ExtensionsBuilding ExtensionsExtension Verif...Extension Verif...Warning about GO at end of SQL FileWarning about GO at end of SQL File
Previous
 
Next
New Post
12/13/2012 12:33 PM
 

All my files end with GO, however, after that, I have the usual comment:

/************************************************************/
/*****              SqlDataProvider                     *****/
/************************************************************/

I think comments should be disregarded...



Erik van Ballegoij, Former DNN Corp. Employee and DNN Expert

DNN Blog | Twitter: @erikvb | LinkedIn: Erik van Ballegoij on LinkedIn

 
New Post
12/13/2012 12:34 PM
 
Related: I have a few empty SQL files, with just a comment:
/* this file is intentionally empty, it is needed for the version cleanup file to work */

These are still reported for missing a GO



Erik van Ballegoij, Former DNN Corp. Employee and DNN Expert

DNN Blog | Twitter: @erikvb | LinkedIn: Erik van Ballegoij on LinkedIn

 
New Post
12/13/2012 12:45 PM
 

Thanks for the feedback, I'll look into removing the comments from the files.

 Cheers,

Nathan Rover

 
New Post
12/14/2012 4:19 PM
 
Hi Nathan,

I actually got this message for SQL files *without* any comments after the last GO. Just empty lines, nothing else.

Peter

Peter Donker
Bring2mind http://www.bring2mind.net
Home of the Document Exchange,
the professional document management solution for DNN
 
New Post
12/17/2012 6:32 PM
 
Hello Erik and Peter,

I've added a little extra logic to the SQL script parser. The issues you've reported with the GO warnings should be resolved now. I've added a bit of regex to take out comments from each command, that when combined with a trim() to remove trailing line breaks, has eliminated the false positives.

Again, thanks for the feedback.

Please let me know if you find any other issue, or have any questions about this update.

Cheers,

Nathan Rover
 
Previous
 
Next
HomeHomeDevelopment and...Development and...Building ExtensionsBuilding ExtensionsExtension Verif...Extension Verif...Warning about GO at end of SQL FileWarning about GO at end of SQL File


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out