Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDNN Open Source...DNN Open Source...Provider and Extension ForumsProvider and Extension ForumsClientAPIClientAPITreeView name uncomfortable and problem maker...TreeView name uncomfortable and problem maker...
Previous
 
Next
New Post
10/2/2006 8:53 AM
 
On my humble point of view, there is a "small" problem with one of the classes that the usercontrol DNNTree uses; the class with name "TreeNode" coincides with the .Net framework's class TreeNode used by TreeView control, as I have had to rename all class variables that have used on my modules to refer to treeview nodes...

What I had as
    Treenode node = NodeHelper.GetNodeFromText(TV.Nodes, DateTime.Now.Year.ToString());
Has been needed to be changed to:
    System.Web.UI.WebControls.Treenode node = NodeHelper.GetNodeFromText(TV.Nodes, DateTime.Now.Year.ToString());

Also, any reference to the DNN TreeNode must be refered by its complete namespace...
                DotNetNuke.UI.WebControls.TreeNode DNNTreeNode;

Shouldn't it, for consistency naming be named DNNTreeNode???

Just a proposal...

Regards and great Job,
Jose Luis

 
New Post
10/2/2006 2:08 PM
 
I agree with the naming, however, unless we are willing to break backwards compatibility, the name has to stay.

 
New Post
10/3/2006 4:05 AM
 
then it's just a matter of deciding if it is left "incompatible" (at least the naming schema) with .net framework or change it and loose the backward compatibility...
anyway  the Casting of these nodes is a thing I don't want to see... as it will have to carry all the namespaces there...

(System.Web.UI.WebControls.TreeNode)NodeHelper.GetNodeFromText(TV.Nodes, DateTime.Now.Year.ToString());

hmm..

 
New Post
10/3/2006 9:39 AM
 

I see nothing incompatible with the naming.  Sure it is inconvenient, but not incompatible.

The whole idea behind namespaces is to allow disparate classes to share the same object names.  Deciding what namespaces you Import/include will change how convenient it will be to access them.


 
New Post
10/3/2006 9:58 AM
 
Jon Henning wrote

I see nothing incompatible with the naming.  Sure it is inconvenient, but not incompatible.

The whole idea behind namespaces is to allow disparate classes to share the same object names.  Deciding what namespaces you Import/include will change how convenient it will be to access them.



Surely it's not, you're right.

I was mentioning only the case in that you have code which manages through Ms treeview nodes and have coded everywhere "TreeNode". then it is "incompatible" with the client api unless you change the code to put the full namespace hierarchy, as I have had to do in order to be able to use other ClientApi controls.

I was trying to mean just that, sorry if my bad english has given my words other meanings I didn't wanted them to have.

Thanks again for your -always- fast response.

Yours,
JL
 
Previous
 
Next
HomeHomeDNN Open Source...DNN Open Source...Provider and Extension ForumsProvider and Extension ForumsClientAPIClientAPITreeView name uncomfortable and problem maker...TreeView name uncomfortable and problem maker...


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out