Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsMediaMediaSimple fix for media module content overlap problem (including Footer)Simple fix for media module content overlap problem (including Footer)
Previous
 
Next
New Post
11/10/2006 5:03 PM
 

We just upgraded from 4.0.2 to 4.3.5 and, of course, our IMAGE modules were changed to MEDIA modules (version 03.02.02).  We had to redefine all of our image links (ugh) but all was ok until we fired up FireFox.  Half of our homepage's primay content was misaligned to the far right of the page and overlapped out right-hand column content (we use a 3-column skin).  This issue did not occur under IE.

Experimenting with the module I discovered that items added to the FOOTER area in the Advanced Settings section also rendered to the right of the module (instead of below) when viewed in FireFox.

After some digging I discovered that the media module wraps its content in a <DIV> tag.  This is fine except that IE and FireFox can differ somewhat in their treatment of content following a DIV.  In our case a large content module following a Media module resulted in the content module being pushed to the right of the preceeding media module (like text wrapping to the right of an image).  The expected line break following the image did not happen in FireFox.

Long story short:  Wrapping a <TABLE> around the media module's <DIV> takes care of the issue.

TO FIX:
Modify the media module's "MediaModule.ascx" file.  (The default file for module version 03.02.02 is only two lines long.)  The following code shows the entire file including lines I added in RED:

<%@ Control language="vb" Inherits="DotNetNuke.Modules.Media.MediaModule" CodeBehind="MediaModule.ascx.vb" AutoEventWireup="false" Explicit="True" %>
<table><tr><td>
<div style="width:100%" ><asp:Literal id="MediaLiteral" runat="server" /></div>
</td></tr></table>

That's it -- our FireFox issue is corrected.  Also any HTML added to the FOOTER setting now correctly renders under the media content instead of to the right of the content.

Cheers!


esmamlin atxgeek.me
 
New Post
1/17/2007 12:14 PM
 

Thanks for the great fix!  We just upgraded DNN on our development servers and it coverted to media modules also, giving us the same problems.  We immediately upgraded the module to the 3.02.03 and the problem was not resolved.  It then caused another problem, causing the images to disappear completely.

There was also an issue with the images being cropped off on the right.  That was resolved in Media 3.02.03, but only because the setting can be adjusted in the modules settings.  This seems like a break from standards where align is controlled by the Page Settings.

Do you know if all of this been reported to Gemini?  We are waiting to upgrade two installations of DNN just because of all the problems with image modules.


Bob
 
New Post
1/17/2007 1:10 PM
 
Hi,

Don't get me wrong, but I don't think introducing more tables to DNN would be a desirable step.  I know there are some differences between interpretation between IE and FF, but I don't think html tables are the right solution for this problem. Tables are meant for displaying tabular data, not for layout issues. If the divs are properly named you could target them from your CSS and deal with the problem there.

I personally feel that dnn and all modules should try to separate content and design by eliminating all inline styles , hardcoded (deprecated) html tags, hardcoded images (which can be quite nasty in multi portal installations), using divs in stead of tables and making sure all divs can be targeted properly from CSS. CSS offers much more flexibility. Are there any plans for making DNN XHtml compliant?

Thanks in advance,

Rudgr
 
New Post
1/17/2007 1:12 PM
 
PS: I do agree with the media module loosing references after an upgrade ;-)
 
New Post
1/17/2007 2:11 PM
 

Is this linked to the problem I experienced recently or completely different ??
I had a problem of Copyright not showing correctly - See: http://www.dotnetnuke.com/Community/ForumsDotNetNuke/tabid/795/forumid/54/threadid/95626/scope/posts/Default.aspx

You can check my screen capture. It seems to me that it is also linked to a problem of display.

DV FX

 
Previous
 
Next
HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsMediaMediaSimple fix for media module content overlap problem (including Footer)Simple fix for media module content overlap problem (including Footer)


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out