For a prayer request/update module (which is much like a highly specialized forum) I have created two custom permissions with PermissionKeys of POST and MODERATE. Although the addition of the custom permissions (in the implementation of  IUpgradable.UpgradeModule) works fine as does the testing of whether the user has one of these custom permissions, I am wondering what values to provide for ControlType in the module's .dnn file.  If, for example a module control would require that the user have MODERATE permission, I can either give the moderator's role BOTH EDIT and MODERATE permission on the module and set the ControlType to Edit OR give the moderator's role only MODERATE permission on the module and set the ControlType to View.  If I set the ControlType to Edit and give the moderator's role only MODERATE permission, the module loading code in Skin.vb recognizes that the user does not have EDIT permission on the module and redirects to the AccessDeniedUrl before my custom code in the module control's page load has a chance to check for MODERATE permission.

So, I'm wondering:

1. Is it better (safer) to set the module definition's ControlType to Edit and provide instructions to administrators of the module that they will need to give the moderators role(s) both EDIT and MODERATE permissions or set the ControlType to View in which case the moderators role(s) will need only MODERATE permission? I'm leaning toward doing the latter to simplify configuring permissions and feel relatively safe as the module control's page load first checks whether the user has MODERATE module permission and immediately redirects to AccessDeniedUrl if he/she does not.

2. Has any consideration at the core level been given to extending a module control's ControlType to include any custom permissions that the module creates? It would be great to be able to set the ControlType in the .dnn file to "MODERATE" for example. Unfortunately, his would require major changes to way that the ControlType is both stored and tested against the SecurityAccessLevel enumeration.

---

Bill, WESNet Designs
Team Lead - DotNetNuke Gallery Module Project (Not Actively Being Developed)
Extensions Forge Projects . . .
Current: UserExport, ContentDeJour, ePrayer, DNN NewsTicker, By Invitation
Coming Soon: FRBO-For Rent By Owner

I was wondering if an enhancement issue was ever entered in support.dotnetnuke.com for this - didn't want to create a duplicate issue if possible. I wasn't able to find any issues with "custom permisson" as keywords when I searched...