Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeUsing DNN Platf...Using DNN Platf...Skins, Themes, ...Skins, Themes, ...No Closing div tag!No Closing div tag!
Previous
 
Next
New Post
8/5/2007 4:57 PM
 

This is a fresh install of 4.5.5.  Hours old.


/Brian C
 
New Post
8/5/2007 5:27 PM
 

BriC:

Just to let you know that I just validated a plain vanilla site I have in 4.5.5 (at validator.w3.org) and it did not say anything about missing tags.  I don't think the problem is with the core.  It is coming from either a specific module or the skin.

I'm using the default skin by the way.

Carlos

 

 
New Post
8/5/2007 7:40 PM
 

CarlosRafi wrote

Just to let you know that I just validated a plain vanilla site I have in 4.5.5 (at validator.w3.org) and it did not say anything about missing tags. 

You're a cruel, cruel man, Carlos- assulting the poor validator with DNN 

 

It is a brilliant tool for BriC to hunt down his problem though.

I guess, you've gotta be cruel to be kind...



 
New Post
8/6/2007 1:19 AM
 

Well, aside from the default.css and the css for the housemenu it validates (felt a bit happy about that) BUT in the process I decided to strip down to some sample skins/containers to see if they would make the difference.

Before going further, as summary:
my original skin works fine on the main page of the site where I fill my regular panes ('contentpane' and 'dashboardpane').  The 'anotherpane' is visible false and since there's nothing on it it just doesn't appear.  And no problem with divs.  Also, the modules were the links module and text/html.

In the 'forums' page I put the forums into the 'anotherpane' (lacking a good semantic term there if you hadn't noticed) and the closing div failed to materialize.  I wrapped my div tags in html comments (in my skin/containers) to identify them and they all appear nicely.  The one that missed was one generated by DNN.

And, as I mentioned, I decided to simplify things for testing.  I left the container the same since it's already only a div tag for content. Then I made a simplistic skin with just the divs related to the "panes".  A nothing skin with only 3 divs -- nothing should go wrong.  And with the forum added that extra div that dnn generates does NOT appear.  Weird.

However, the forum developers claim to not be adding the div.  No divs in their formatting they say.  The div looks like this:

<!-- Start_Module_370 --><div id="dnn_ctr370_ModuleContent">

On other pages (without the forum) I get

<!-- End_Module_369 -->
</div>

but not on the one with the forum. Instead it produces:

<!-- End_Module_370 -->
    </table></div>
<!-- previous div ends simple container --></div><!-- anotherpane closes with previous div -->

Note that the 2 divs there are from my container and my skin.

If anyone cares to experiment/confirm/debunk: here's the container and skin for download (sorry they're not packed, you'll have to ftp to install).

http://web.omnidrive.com/APIServer/public/D5YjLkGxHrctLaWSSidYCKW1/SimpleDimpleContainer.zip

http://web.omnidrive.com/APIServer/public/voaWapg5QhMUhzrBv06QWwJw/testskin.zip


/Brian C
 
New Post
8/6/2007 7:00 PM
 


I have to believe that the issue is NOT BriC's skin- as the report from validator.w3.org appears to confirm the missing div end tag on the forum here on DNN:

  1. Line 7723, Column 17: end tag for "DIV" omitted, but its declaration does not permit this.
    					

     

    • You forgot to close a tag, or
    • you used something inside this tag that was not allowed, and the validator is complaining that the tag should be closed before such content can be allowed.

    The next message, "start tag was here" points to the particular instance of the tag in question); the positional indicator points to where the validator expected you to close the tag.

  2. Info Line 7655, Column 129: start tag was here.
    …ign="left"><!-- Start_Module_2108 --><div id="dnn_ctr2108_ModuleContent">
     

I know that there are changes to the core that need to be made in order to get high-level compliance out of DNN, but I am not sure what those changes consist of. I suspect that things like text case inconsistencies, and missing closing tags are a part of the problem.

*edit*

OBrienIT and DNNCreative seem to be the experts in the matter presently.



 
Previous
 
Next
HomeHomeUsing DNN Platf...Using DNN Platf...Skins, Themes, ...Skins, Themes, ...No Closing div tag!No Closing div tag!


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out