Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeUsing DNN Platf...Using DNN Platf...Skins, Themes, ...Skins, Themes, ...Why .Normal and the core CSS classes must go...Why .Normal and the core CSS classes must go...
Previous
 
Next
New Post
3/30/2010 7:26 AM
 

I agree it should be easier to have no styling as a basis.
The problem is default.css IMO not the existance of the .Normal or .Head class.

(BTW, you can set the cssclass for the title skin object, Head is just the default)

IMO we need versioning for default.css, so if a skin is for skin engine version 5 or DNN 4 it will load the current version, if it's for "the new" skin engine 5.5 it will load the cleaned up version of default.css.

That way we can support "old" skins and allow the creation of cleaner new skins

IMO this is a very obvious point in time to rework default.css, because now that DNN has seperated the admin and host modules in DNN 5, a large part  of default.css is useless.
A lot of styling in there is for specific admin modules, where this really should be in the module.css for that module, so the css does not get loaded if you use a different filemanager for instance.

 
New Post
3/30/2010 7:37 AM
 

I agree 100% with removing any DNN injected styles or span tags.

Another huge issue is injecting span tags like:

<h2 class="c_title"><span id="dnn_ctr356_dnnTITLE_lblTitle" class="TitleHead">Sponsorsspan>h2>

All this makes skinning alot harder for everyone & is un-needed. To be honest I am not sure why it was put there in the first place. Designers should be able to skin their DNN sites with out having to worry about all the un-needed crap that DNN injects to their site.

As Sebastian has said & I agree with to preserve backwards capibility - their needs to be couple of settings in the host menu:

  1. turn off injecting of DNN classes
  2. turn of injecting of DNN span tags
  3. disable loading of default.css & portal.css files (only slows a DNN site down)

The other thing I think DNN also needs to do is used compressed versions of css & js files by default to help improve the proformance of DNN.

Basically include two of every file - EXAMPLE: default.css (compressed version for better performance) & default-uncompressed.css (uncompressed version for easier editing). This should be done for all css & js files include in DNN.

EDITED: Updated my post to include request to compress all files by default ;)

 
New Post
3/30/2010 7:39 AM
 

Jon,

Apologies if you thought I was trying to be smart regarding the workaround, my reference to a solution was included simply as a pointer for those reading the post who might be looking for a workaround to the issues of multiple CSS files and cascading. As Timo also pointed out you can specify the class of the titles in an XML file, but the ideal situation, which is what you're getting at, would be that it's all left unstyled, so we can define this ourselves and keep the CSS as clean as possible.

As a designer I completely agree that there are some improvements to the use of CSS within the framework that can be made. I am currently going through the default.css file myself, creating a template file for use on my own skins and there's a lot of inconsistency regarding fonts, sizes and so on.

Regards,

Rick.



PSDtoDNN - You supply the artwork... we'll build the skins!™
Website | Twitter | YouTube | Skype
 
New Post
3/30/2010 8:19 AM
 

I feel your pain i have been deleting the base portal.css and default css since the beginning.

I always had weird issues with the normal classes, the overriding of the normal classes and still in the latest versions as well the injected <span class="normal"  around my block contnent making the site render as invalid.

Ofcourse you can set the css classes in the skinobject calls but if you forget one the problem begins with ugly red links some might always pop up or some 3rd party module uses this setup.

I also dont like putting everythign in a span so I made my own moduletitle skinobject that get rid of all  spans i dont need

<h1><span class="head" id="dnn_ctr???_dnnTITLE_lblTitle">The Title of this container</span></h1>

becomes

<h1>title</h1>

Basically what dnn needs are a nr of custom skinobjects that allows templated output

for instance my moduletitle works like <Schwing:Title Template="<h1>{0}</h1>"/>

I would like to see some serious improvement in ths all the extra features is ncie but eg. with governments projects I have lost agains other service providers with non dnn based solutions that could guarantee the clean ouput that was required

 

 

 

 

 

 

 

 

 
New Post
3/30/2010 10:20 AM
 

I agree with this being an issue. This has been the source of many headaches and long days for me. Granted, 4 yrs into it, I have a good base css that overrites the default, but this is hardly ideal. And, as Jon mentioned, it all changes once you begin using ems. I used them for about a year and finally went back to pxs just for the simplicity. This is also causing problems for those just getting into DNN skinning. I mean, don't we want this to be something easy for people to get into. The easier, and more straightforward, the more people will stay with DNN and not go to something else and the larger DotNetNuke will grow.

I think the ability to turn off the injection of the additional spans and classes would be fantastic. And, if there were a way to set that in my skin file, all the more better! I also understand the module developer's argument, to an extent, as I have had this discussion at DNN user groups on more than one occasion. They are concerned with keeping the layout that they have come up with and think is best, however, they keep missing that what is best for their setup may not be best in mine. 

This consistently seems to be a battle between skinners and module developers. And rightly so, sort of. When applying a purchased skin, the particular module may not have been considered and therefore is lacking the necessary styles to make it appear as it should. However, when I am doing a custom skin, I can style for that module as needed.

But, I think this thread was started with more of a focus on the core. Again, I think the purpose of their approach is a valid one, to maintain consistency. Which, is what we are trying to do as skinners, isn't it? As Cuong Dang pointed out in the session, "Bridging the Gap Between Module Developers and DotNetNuke Designers" at the 2009 Day Of DotNetNuke, a simple, consistent naming pattern needs to be used.

All of that to say, I like the idea of being able to turn off the injection of spans and classes.



Ralph Williams, Jr.
UX Designer / Front-End Web Developer
www.RalphWilliams.com
Ralph Williams Consulting
Twitter: twitter.com/ralphwilliams

Professional DNN7: Open Source .NET CMS Platform
 
Previous
 
Next
HomeHomeUsing DNN Platf...Using DNN Platf...Skins, Themes, ...Skins, Themes, ...Why .Normal and the core CSS classes must go...Why .Normal and the core CSS classes must go...


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out