Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeOur CommunityOur CommunityGeneral Discuss...General Discuss...Performance Tip Performance Tip
Previous
 
Next
New Post
4/30/2007 9:04 AM
 

I know it may be picky, but even if the check is only for authenticated users it is a wasted check if we are not running with defaults and some of us may feel that our passwords are strong enough to even keep usernames like "admin" and "host". 

This may not be a huge impact, but all these little ones add up and it is very easy to remove for people who have had the warning and no longer need the code checking for this on every single request.

I think a security measure like this is much better served without resorting to code.  Creating a blog post and linking to it from the next newsletter should be sufficient.  But it is a subjective topic, so I can offer some other ways to do it in code that would be less impact.

First, the declaration of the message string is done outside of the check where it is used, so that string allocation is always performed even if it is not needed.

Second,  there is already a place in the code that checks if the user is authenticated on every request - OnAuthenticateRequest of the membership module.

Third, and the best I can think of right now if it has to be done in code is to move it to the control panel, which already has logic to only show for the people that are being targeted with the message.


DotNetNuke Modules from Snapsis.com
 
New Post
4/30/2007 9:38 AM
 

FYI this was originally added after a request from a hosting provider. They were finding that their users were often not using their automated installation (which changed the default passwords), but instead uploading a copy of DNN themselves and doing a normal install. The hosting provider was being agressively targetted by hackers who were using dns records to determine the hostnames of sites on their servers, and then trying to log into them via the known defaults. After this they were vandalising sites, deleting content and in general causing large scale damage. There were also further unconfirmed reports that hackers were using search engines to locate dotnetnuke sites and try known defaults.

In both these cases, there were likely to be large numbers of users who would only visit the dotnetnuke site to download updated versions of the core & modules, and were unlikely to read blogs, so enforcing the check in the code was a much better way of fixing this issue, than relying on user education.

BTW, you can keep usernames as admin and host, the check is only done on default username/password combinations.

Note: this forum is for announcements only, please use an alternative forum if you wish to discuss this further.


Buy the new Professional DNN7: Open Source .NET CMS Platform book Amazon US
 
New Post
5/1/2007 8:30 AM
 

Ok, it looks like we are now in the Chat About It forum, so we can discuss this a little further.

I see where the querystring variable does not get added unless there is a username/password combination on the defaults so you can use admin or host as a  username as long as you don't use the default password.

My problem with this approach is that even after the message has been delivered and the problem rectified, the code still has to keep checking on every login for the username/password combination and then on every request to see if it should display the message.

Here is a better way, that will even help deliver these kinds of messages in the future. 

Create a simple message module.  Then on upgrades do the check for whatever the administrator needs to be notified of, and if they need the message delivered inject a message module instance into their home page and make it only visible to who needs to see it.  If the check can not be done during the upgrade, the process could also take place on application start using the EventQueue.

This way, once the problem is rectified they will be able to easily remove the message module, and not suffer a performance hit.

I also think these types of messages should still have a security bulletin created and advertised to people who may not be doing the upgrade.  Afterall, if it is worthy of adding code, it certainly must be worthy of notifying other people that may not ever see that code executed.
In the case of the hoster that requested this check, they should also be notifying their customers through e-mail, etc.


DotNetNuke Modules from Snapsis.com
 
New Post
5/1/2007 2:39 PM
 

cathal wrote

BTW, you can keep usernames as admin and host, the check is only done on default username/password combinations.

Can this be turned off for localhost portals? I find it annoying on my local development portal

 
New Post
5/1/2007 8:45 PM
 

The only way the message can be turned off right now is by removing the lines in the first post of this thread.

 


DotNetNuke Modules from Snapsis.com
 
Previous
 
Next
HomeHomeOur CommunityOur CommunityGeneral Discuss...General Discuss...Performance Tip Performance Tip


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out