Page 4 DNN hangs loading edit mode with 50+ modules on page

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

Home All Forums

Home

Using DNN Platf...

Performance and...

DNN hangs loading edit mode with 50+ modules on page

1/31/2014 6:38 PM

Richard Howells

www.dynamisys.co.uk
Joined: 3/26/2006

Posts: 2001

Re: DNN hangs loading edit mode with 50+ modules on page

Mike suggestion is also a good one. If the content managers can be relied upon not to break the structure.

It relies on the content manager a) suspending belief that such a list won't show bullet's all over the place b) retaining the necessary CSS class c) remembering to add new logos as list items.

That's fine if the content manager is up for it. The OP did say "We don't want to add HTML structure in the HTML module, then the content manager would probably break the HTML structure when trying to add or remove logo's. That's why we've decided to use the DNN module containers as grid items, so the HTML module does contain any HTML structure that can be broken by the content manager."

Best wishes,
- Richard
Agile Development Consultant, Practitioner, and Trainer
www.dynamisys.co.uk

2/1/2014 7:24 AM

Sebastian Leupold

www.dnnwerk.de
Joined: 3/8/2004

Posts: 46212

Re: DNN hangs loading edit mode with 50+ modules on page

another option would be using free DNN Form and List module (dnnfnl.codeplex.com), you may easily provide an item template and the page editor may add/edit/remove single logos as needed.

Cheers from Germany,
Sebastian Leupold

Speed up your DNN Websites with TurboDNN

5/7/2014 5:31 AM

Je Moeder

Joined: 5/7/2014

Posts: 2

Re: DNN hangs loading edit mode with 50+ modules on page

First: Im no software developer, so my view could be complety wrong.

I have experienced the same problemens. I have a skin over 100 panes and 30 modules the website is very slow in edit mode.- Ofc, having more the 100 panes and 30 modules is silly -

One of the reasons the skin hangs in edit mode is because the way append actions are done in ModuleActions.js. These actions are in an "if-loop", in my case resulting over 2500 separate DOM manipulations(!!). I think it is wise to use append after the loop is finished

p.e in the ModuleActions.js, the buildMoveMenu function:

orginal:

for (i = 0; i < panes.length; i++) {
var pane = panes[i];
if (paneName !== pane) {
id = pane + moduleId;

htmlString = "

" + opts.movePaneText.replace("{0}", pane);
parent.append(htmlString);
parent.find("li#" + id).click(function () {
moveToPane($(this).attr("id").replace(moduleId, ""));
);
}
}

In this loop, for each pane you have on your website,the script has to "dive" twice into the DOM and make changes. In my case 30 modules * 100 panes = 3000 DOM manipulations for the movetoPane action alone. This seems bad pratice, it is best to keep DOM manipulation out of the loop, making the script run much faster. I have changed this to:

var htmlStringContainer = new String;

for (i = 0; i < panes.length; i++) {
var pane = panes[i];
if (paneName !== pane) {
id = pane + moduleId;
htmlString = "

" + opts.movePaneText.replace("{0}", pane);
htmlStringContainer+=htmlString;
}
}

// loop is done, append the HTML and add moveToPane function on click event
parent.append(htmlStringContainer);
parent.find("li").click(function(){
moveToPane($(this).data("paneName"))
})

I make DNN run much fasting in edit mode, i suggest no more appending in loops

5/8/2014 2:31 AM

Je Moeder

Joined: 5/7/2014

Posts: 2

Re: DNN hangs loading edit mode with 50+ modules on page

mmh, seems forum ate some of my code.

orginal script:

 for (i = 0; i < panes.length; i++) {
	 var pane = panes[i];
                if (paneName !== pane) {
                    id = pane + moduleId;
					                    
                    htmlString = "<li id=\"" + id + "\" data-paneName='"+pane+"'>" + opts.movePaneText.replace("{0}", pane);	
		    parent.append(htmlString);	                    													
                    parent.find("li#" + id).click(function () {
                       moveToPane($(this).attr("id").replace(moduleId, ""));
                    );
                }
            }

modified script:

var htmlStringContainer  = new String;
	
	for (i = 0; i < panes.length; i++) {
                var pane = panes[i];
                if (paneName !== pane) {
                    id = pane + moduleId;
		    htmlString = "<li id=\"" + id + "\" data-paneName='"+pane+"'>" + opts.movePaneText.replace("{0}", pane);	
	 	    htmlStringContainer+=htmlString;                    
                }
            }

	// loop is done, append the HTML and add moveToPane function on click event
	parent.append(htmlStringContainer);
	parent.find("li").click(function(){							
		moveToPane($(this).data("paneName"))
	})

5/8/2014 3:54 AM

cathal connolly

www.cathal.co.uk
Joined: 4/9/2003

Posts: 9676

Re: DNN hangs loading edit mode with 50+ modules on page

thanks Je - I've added a note regarding the suggestion to the jira ticket and assigned it to 7.3.1 (7.3.0 is locked down already), so hopefully it will get evaluated and added in that release. Thanks for the contribution.

Buy the new Professional DNN7: Open Source .NET CMS Platform book Amazon US

Page 4 of 6

Home

Using DNN Platf...

Performance and...

DNN hangs loading edit mode with 50+ modules on page

These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
No Flaming or Trolling.
No Profanity, Racism, or Prejudice.
Site Moderators have the final word on approving / removing a thread or post or comment.
English language posting only, please.

Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

DNN Corp. (DotNetNuke)