Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsForumForumIs the subject input safely filtered or encoded?Is the subject input safely filtered or encoded?
Previous
 
Next
New Post
1/9/2006 6:57 AM
 

Oh, I hope nobody takes what I wrote verbatim. That was more a collection of notes and good practices than a persrcription. I haven't looked at the details of the Forums module, I'll have to look at your XSSController more carefully.

However, what can we do to raise awareness of this issue in other modules. I just did a quick test with the default FAQ module. If you grant Edit permissions on the FAQ module to a broad group of users, any of those users can enter a Question or Answer. Then they simply have to set the Texteditor to  "Basic", then text mode to "Raw" and then they can enter any <SCRIPT> that they want.


WildVoice.com Michael Levy - Are you ready to be heard? WildVoice.com
 
New Post
2/7/2006 6:00 PM
 

I finally got a chance to look at the Forums module XSS Controller class. I think it is a little naive in how it filters for hostile script. It seems to only look for scripts in well known HTML elements (like <SCRIPT>) but it misses some well known XSS vectors. Also, the version I saw in 3.20.01 seemed ot have many of the Elements commented out in the function XSSGetAll, so this is completely neutered.

So, I belive the DNN Forum mdoule is vulernable to XSS even in the body of  a posting. Try this (Please don't do this on a production server or a real forum, do it on your dev machine)

Edit a post and enter the following with the basic text box:

<div style="width: expression(alert('xss'));"></div>

(Since I entered this in RichText mode it should be encoded by FTB and this post should be safe to view)

A <DIV> is often consdiered a safe tag for scripting. However, the STYLE attribute is not safe. So, if you allow users to enter style attributes on any tag, you are vulnerable to XSS. Also, note that browser default to Javascript, so you don't have to enter a "Javascript" url scheme to get script to execute. That is important becuase the XSS controlle rin the forum module explicitly tests for the string "javascript".

You want to lose a lot of sleep? Check out the sample XSS attacks at See http://ha.ckers.org/xss.html.


WildVoice.com Michael Levy - Are you ready to be heard? WildVoice.com
 
New Post
2/7/2006 6:52 PM
 

And before you discount me, check out this story - http://namb.la/popular/ and his technical explanation - http://namb.la/popular/tech.html. He used a <DIV> tag with script embedded in a a style attribute to create a XSS worm on MySpace.com.

A great story.

A great warning for those of us building or operating community oriented web sites.


WildVoice.com Michael Levy - Are you ready to be heard? WildVoice.com
 
New Post
2/8/2006 12:38 AM
 

I am awaiting a class Cathal is adding to the core to handle xss.  It takes the approach of a list of allows instead of a list of exceptions.  Until this is complete, we will settle with what we have because we don't have enough resources to do more.

 


Chris Paterra

Get direct answers to your questions in the Community Exchange.
 
New Post
2/8/2006 10:18 AM
 
Any estmiates on when that class will be available for others to use? I'm about to undertake developing my own, and I'd much prefer to keep levaraging core DNN.

WildVoice.com Michael Levy - Are you ready to be heard? WildVoice.com
 
Previous
 
Next
HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsForumForumIs the subject input safely filtered or encoded?Is the subject input safely filtered or encoded?


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out