Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsGalleryGalleryImages strored 3 times????Images strored 3 times????
Previous
 
Next
New Post
2/3/2006 8:55 PM
 

Jeff,

It's not that simple to just switch that on.  There are other things to consider besides deleting the image.  This means we have to verify all 'destructive' functions and add confirmation informing the user it is a destructive task. 

Right now we are focused on the dataprovider.  Once this is smoothed out I think we will drop a beta with it ASAP and then work on fine tuning.  This dataprovider is the first major step to this module being overhauled (in a good sense).

 


Chris Paterra

Get direct answers to your questions in the Community Exchange.
 
New Post
2/4/2006 12:34 AM
 

First of all I never implied it was simple.  Second of all, it IS quite simple. Some of code to provide this ability is already in the module, some of it has been removed. There doesn't have to be any confirmations, its just another one of the options for configuring the module.  I changed like 5 lines of code in my copy and now I can switch whether source is kept or not. I have to change the setting in the database directly as I did not take the time to add it to Settings.ascx, but I can control it now.

But, thirdly and my main point is, that Tam's post seemed to be implying that a user merely has to make a choice on whether or not to keep the source file and that is not correct. There is no config option for a user to decide whether to "keep source" or not and cannot switch it by editing settings in the database either. Its hard coded to always keep source (the third, pehaps un-needed copy) which is what the original post was commenting on.  But the option used to be there back when it was TTTGallery.

And lastly, I would have to say that storing metadata in a database about disk files has always been a bad experience for me. The code to keep disk vs. tables in sync is always a pain. Its far too easy to move, add, rename or delete a disk file and then the database is out of sync. At least as how the metadata is currently stored in the same folder as file, then when files are moved the metadata can travel with it.

I would much rather have the project team spend its time making features that are ABSOLUTELY required, such as the settings.ascx issue work and be available in a download than have the team write a bunch of sync code that may never be right and very easy to break.  I find it very irritating that a software product exists where the most basic function such as configuration flat out doesn't work as delivered when it takes all of 1 hour to change the code and make a new download package. And yet this known to be broken download is the only version that is available and every single user of it has to spend their own hour trying to figure out what is wrong, research the fix and apply it.

 
New Post
2/4/2006 12:29 PM
 

Jeff, I really don't appreciate your attitude.  I am sure you can care less but you are not the only person who uses this module.  If you don't like the way things work or how fast progress is being made, you can choose not to use this module anymore and go down the path of your own custom module started from this one.  I don't care how long it takes to do one thing, every decision on the direction of this module is one made which follows an 80/20 rule.  This rule is that we want to fill 80% of the uses cases and not spend every minute trying to please the other 20%.  Just because you consider it absoutely required does not mean that everyone else feels the same way.  I would take such criticism much easier if this was not a 100% volunteer effort by myself and my entire team.  In the past you have been helpful and pointed myself and others in the right direction, I am not sure what set you off now but if it was me it was not my intent.

 

 


Chris Paterra

Get direct answers to your questions in the Community Exchange.
 
New Post
2/4/2006 10:48 PM
 

I have inadvertantly changed the topic here and I failed to make my point. I was trying to say that the "configuration" feature is what I would deem "absolutely required", not this "keep source" feature. You would agree that having the settings.ascx screen to set the options should at least open, right? I'd be surprised to learn of a user who wouldn't agree that in 100% of the cases that this basic ability should work.  Yet in the 3.0.11 download the first thing I do after adding the module to a page is go to "Configuration" and boom, error. Hmmm. it was OK in 3.0.10.

So, what me set off was that the most basic feature is broken and the time I wasted trying to figure out what I was doing wrong.  I eventually learn that someone has figured it out and that the fix doesn't even require a recompile. Yet, the 3.0.11 has existed for weeks with this serious flaw in it that affects all users who wish to even change just the title of their gallery. And a fix exists which requires very little regression testing and a new download could be built (changing only 1 file from 3.0.11) and save the entire community untold wasted time.   But instead the team is working on moving all the data into the database, which in the long run may be needed and a good idea, but in the short term seems to work just fine.  And I don't recall much discussion on this board about how painful its been without this and how much trouble the XML metadata solution is causing. I am doing DotNetNuke websites in my spare time as well and I would think you would want to spend your time on the most "bang for the buck" items.

tclaffy, if you're still reading, I'll post the code changes I made to allow the ability to choose not to keep the _source files. These are the largest of the three files. They are only needed if you want EXIF data to display completely (it displays only partial data without having access to the source image) and to allow "download" of large resolution source files. If the source is missing, then "download" delivers the resized file. My solution requires direct database editing to change the option as I didn't want to get into editing the UI.

 
New Post
2/6/2006 12:50 PM
 

tclaffy, to add back in the ability to "Keep Source" requires a couple code changes and recompile of the Gallery Module:

The code that deletes the "source" image after upload, after resizing and generating Thumbnail
is already in place from a prior version of the Gallery known as TTTGallery.
The code that downloads the _source version if it exists or the resized version is also in place and working.

FILE: \DesktopModules\Gallery\Components\Configuration\Config.vb:

Line 161 - Change default behavior from "Keep Source" to "Not Keep Source"
' Private mKeepSource As Boolean = True
Private mKeepSource As Boolean = False

Line 912 - Restore the "Keep Source" setting from the ModuleSettings, default if not available.
'<JJK. allow KeepSource to be "restored" as a setting. must manually insert into ModuleSettings table.
mKeepSource = CBool(GetValue(settings("IsKeepSource"), CStr(mKeepSource)))

FILE: \DesktopModules\Gallery\Components\Configuration\Config.vb:

Line 89 - save "Keep Source" setting during initial module configuration.
' <JJK. add KeepSource back in as a saved setting.
ctlModule.UpdateModuleSetting(ModuleId, "IsKeepSource", "False")

For Existing Modules that were placed before the code changes or where want to
change the setting, you must MANUALLY update the database for ModuleSettings.

Using SQL Query Analyzer or other direct SQL tool:

select * from ModuleSettings order by moduleid desc -- to find most recently added modules

insert into ModuleSettings (ModuleId, SettingName, SettingValue) values (-YourGalleryModuleID-, 'IsKeepSource', 'False')

or

update ModuleSettings
set SettingValue = 'False'  -- or 'True' to keep the source image.
where
  ModuleId = -YourGalleryModuleID-
  and SettingName = 'IsKeepSource'

TODO:
I did not add the option to the Settings.ascx to change the option in the configuration screen.
That would require a checkbox object, localization tags, editing the tab order and such. Plus code
to save the setting such as (about line 400) in Settings.ascx.vb:

ctlModule.UpdateModuleSetting(ModuleId, "IsKeepSource", chkKeepSource.Checked.ToString)

I didn't do that since I don't need to change it for my purposes

 
Previous
 
Next
HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsGalleryGalleryImages strored 3 times????Images strored 3 times????


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out