I have just started using the forum module and found that the ForumsearchHelper module that creates the where clause for search sql statements produces Microsoft SQL formated code.  This should really be done in the data provider as other databases don't support some of the conventions used by Microsoft, such as [] around field names, N' in front of strings, etc.  If functions such as format field and format string were done in the data provider, different databases could be handled with just a data provider.

Thanks

Thanks for you response.

The reason I found this flaw is I use Mysql as my database and have written by own dataproviders for dnn and all the core modules.  The forum module is the first that I have had to modify "non provider" code in order to get it to work, otherwise the data provider design has worked well and I was able to easily upgrade from 3.0 to 3.1 DNN without the worry of remembering changes made outside the providers.

My testing has this to be the only problem so far.  I didn't expect a fix any time soon, I was mainly letting you known so that in the future you can get the module to work better with different providers