Hi,

I wrote a module the hits the database fairly frequently and I seem to run into the : System.InvalidOperationException: Timeout expired. The timeout period elapsed prior to obtaining a connection from the pool. This may have occurred because all pooled connections were in use and max pool size was reached. exception fairly frequently.

I think it has to do with the way I'm accessing the database.  in my sqldataprovider.cs file, I have alot of this type of access:
try
            {
                SqlHelper.ExecuteNonQuery(ConnectionString, GetFullyQualifiedName("LocationUpdate"), LocationID, ShortName, LongName, MenuID);
            }
            catch (Exception e)

I think that this is resulting in the connections being held longer than intended.  I seem to recall (but cannot find) and good discussion on connection management in the DNN world.

So, should I be explicitly opening the connection, making my call, then closing/disposing the connection?  Or am I all wet?

Thanks in advance.

fair enough,  I have no explicit closes anywhere.

when reading from the database, I have this:
public override IDataReader GetLocations(int PortalID)
        {
        try
            {
                return (IDataReader)SqlHelper.ExecuteReader(ConnectionString, GetFullyQualifiedName("LocationListGet"), PortalID);
            }
            catch (Exception e)


Then in the controller class:
public List<Location> GetLocations(int PortalId)
        {
            return CBO.FillCollection<Location>(DataProvider.Instance().GetLocations(PortalId));
        }

Should I be doing something more like:
public List<Location> GetLocations(int PortalId)
        {

IDataReader myReader = DataProvider.Instance().GetLocations(PortalId);

         List<Location> myList =  CBO.FillCollection<Location>(myReader);
myReader.Close();

        return myList;
        }

thanks!