Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeUsing DNN Platf...Using DNN Platf...Administration ...Administration ...DNN 5.6.1 critical security error -- needs attention!DNN 5.6.1 critical security error -- needs attention!
Previous
 
Next
New Post
3/22/2011 2:17 PM
 
I have a customer with a DNN 5.6.1 site that had ALL of the containers throughout the site changed by a user with only the Registered/subscriber role and Page view and edit on two pages.

The user was in the module setting area. He choose a module container and then in the basic settings area in the color area he typed yellow. The user wanted all of the modules on his page to have a yellow background so he choose apply to all modules. The results were that he changed ALL module containers on the site to his selected module container and turned ALL modules container backgrounds throughout the site.

I would not have believed this if I had not seen this with my own eyes - he had to restore the site from a back-up.  Can we get someone from DNN to look into this very disturbing issue.  The site owner want to make sure this does not happen again.
 
New Post
3/22/2011 9:39 PM
 
DNN has very poor security granularity once a user has PAGE Edit permissions
 - this has been a huge weakness in DNN for a long time
- and frustratingly an area that has had very little done about it.

Its not that different to the fact that any user with Page Edit permissions on a SINGLE PAGE can ADD a new Page - but if they forget to set edit permissions to the new page - it does not automatically allow them to see the new page - had a user on a site add about 20 blank pages to the ROOT - causing an interesting mess - because he could not see the new PAGE he was trying to add.
Also there is no way to prevent them adding PAGES to any level on the site - another huge weakness.

Also any of the COPY to all pages options, include module on all pages, copy to descendent's are all available to anyone with said PAGE Edit permissions.

The permissions system really needs an overhaul if DNN is to continue to compete in the commercial CMS management arena - but im guessing such features are not likely to make it down into the CE edition of DNN given the directions management are currently headed with PE and EE.

What is needed for starters is a new level of security.

PAGE MANAGEMENT

Which controls if a user is allowed to MANAGE pages - add a page - delete a page - move a page etc

PAGE MODULE MANAGEMENT

Which controls if a user is allowed to MANAGE the modules on a page -  add a module - delete a module 

PAGE EDIT

Which would then control if a user is allowed to EDIT the content on a page only - NOT add pages or modules.

We already had MODULE EDIT effectively but it to could benefit from some granularity ... but at the moment a user with MODULE EDIT can delete the module they are working on - and stuff up other area - such as the event listed in the OP.

All those features should be turned OFF unless the user had PAGE MANAGEMENT for example.

====

The other significant weakness at PAGE MANAGEMENT level is that once you have PAGE EDIT currently you can add a page anywhere in the system - there should be some level of control over this - that being if you have PAGE EDIT - you should NOT be able to add a page above your page level possibly.

Also getting back to current PAGE EDIT permissions and ADD PAGE - at a minimum it needs to copy the permissions of from the page that the user is currently on - so that if the user DOES have the ability to add a page then he will get permission to edit the new page.

Westa
 
New Post
3/22/2011 9:51 PM
 
Seriously this is an architecture issue in DNN that needs to be dealt with on all platform levels from CE thru to EE.  And doing so would greatly advance the commercial long term potential of the product.  

And ironically - it would not be that difficult a task - the permissions provided is already modular enough to allow the additional permission states - what is more needed is a pass thru PAGE SETTINGS, MODULE SETTINGS, CONTROL PANEL and TABS MANAGER to  better allocate tasks and actions to roles.

Westa
 
New Post
3/23/2011 8:45 AM
 
Wes,
Thank you for your in-depth explanation.  This underscores an immediate fear and a long-term fear. The immediate fear was that this was not a bug that was introduced in 5.6.1, but a deep seeded flaw in DNN and the long-term fear that as DNN moves forward with CE and PE that the community edition will not receive some much needed corrections and functionality.

The site where the Page Edit flaw came into play is a 300+ page site with 30+ users with the role registration/subscriber and each of 30+ users have been granted PAGE EDIT on one or two pages. The idea of course was with Page Edit that they should be able to add modules and content to their own pages, but not make any changes to other parts of the site. However, as I stated in the original post, with only PAGE EDIT privs this users changed EVERY container on EVERY page throughout the site. This change was very dramatic because the user thought school bus yellow would be a nice background color for all of the containers on his pages and to save himself time he selected apply to all containers. He of course thought the change would only effect the two page where he had PAGE EDIT privs, but not in DNN, it effected the entire site. He turned the ENTIRE site yellow - the entire site! The sinister part of the problem was that you could not simply go to the page and remove the apply to all modules  check mark and make everything o.k.. The container modules through out the site that were not set to the page default did not come back so the only option was to visit the 300+ pages and correct the module containers that you wanted or restore the site from the latest back-up.  Restoring the site from backup was what we had to do and this of course meant that all of the changes that 30+ people had made since the previous night's back-up were lost and this is a very active site so you can guess that there are a lot of unhappy DNN users.

Wes, is correct this DNN security flaw needs to be addressed by DNN and it needs to be in the Community version.  DNN has advertised it's great security, but if a single user with very limited privs can turn an entire site Yellow then who needs hackers.  I am suggesting that all DNN users, especially Community users, reply to this thread as a form of an OPEN LETTER TO DNN requesting that this DNN's security flaw must be addressed immediately.

If anyone has a better idea of how to escalate this issue into action lets hear it.

Judy
 
New Post
3/23/2011 8:49 AM
 
I would suggest you log it as a bug on http://support.dotnetnuke.com - alternatively - if it is a major issue for you site.
You may need to fork away from the main dnn build and add in the features you need.

Westa
 
Previous
 
Next
HomeHomeUsing DNN Platf...Using DNN Platf...Administration ...Administration ...DNN 5.6.1 critical security error -- needs attention!DNN 5.6.1 critical security error -- needs attention!


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out