You absolutely can use static methods in your controller class.  In fact we started doing that for most of the core framework as we were updating methods.  The only thing you need to watch out for is if your method requires you to maintain state, in which case static methods are not appropriate.

---

Joe Brinkman
DNN Corp.

Hi Fabien,

Of course you can use static methods for your own modules. DNN don't do it simply because it's not optimal for a CMS to have all controllers using static methods. When a static class/method is called, the memory used is never released. Now imagine if you have undred modules doing the same! From MSDN:

"As is the case with all class types, the type information for a static class is loaded by the .NET Framework common language runtime (CLR) when the program that references the class is loaded. The program cannot specify exactly when the class is loaded. However, it is guaranteed to be loaded and to have its fields initialized and its static constructor called before the class is referenced for the first time in your program. A static constructor is only called one time, and a static class remains in memory for the lifetime of the application domain in which your program resides."

Moreover it's not always a good idea, because all members (fields, variables, etc.) have to be static. There is possible case where this could generate problems like sharing the same value from different calls.

On the other hand, a classic module use the singleton pattern for the SqlDataProvider part. This is more efficient because several module instances can share the same db connection.

Gilles

---

We (team members) are Humans offering their knowledge, their work and their spare time FOR FREE to benefit the community. It would be so particularly appreciated that your messages begin with "Hello" and end with "Thank you" or any other form of politeness. Ask yourself what your reaction would be, if you were approached by me (a total stranger) on the street to ask you something without saying "Hello" nor "Thank you"? After several years of services dedicated to the community, I begin to be tired to read requests without any form of politeness.