var aaa = 1  and   int aaa = 1 both map to an Integer = but to be honest using var aaa really makes for lazy code.

But having said that - given i would be questioning the values that are being inserted into the variables not the use of var or int.

in this case you are showing different code passing in different variables to your test functions - in this case the Value of hfFriendId is the one I would be suspect of.

But again seriously - STOP using vars - it makes for code that you will never understand in the future.  Yes vars do have a place when using linq and other complex constructs - but for day to day coding they really should be avoided - if you are using an int define it as an int.

Westa

Which come down to the same questions - i would be looking at the validity of the values you are using.

Look at base.PortalId for starters - traditionally we get PortalId from portalsettings.current.PortalId - i would check that there is an actual value in base.PortalId.

Westa

At this point its down to user error.

Show us the entire block of user code that is causing you issues.  You keep showing us small lines of code without context.

Try doing something like this

Int32 thisPortal = PortalSettings.PortalId;
Int32 thisFriendId = 97;

Debug at this point -

UserInfo InitiatingUser = UserController.GetUserById(thisPortal , thisFriendId);

Int32 testUserId = InitiatingUser.UserId;

Debug again at this point

There is no reason whatever why this would not work - what im willing to bet is that you still have a var mapping issue or a typo burried somewhere.  There are litterally millions of websites and modules in use all over the internet that work with this exact same code.

Westa