Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeUsing DNN Platf...Using DNN Platf...Administration ...Administration ...Print Module not showing for unregistered usersPrint Module not showing for unregistered users
Previous
 
Next
New Post
1/5/2007 10:24 AM
 
i've been looking into this briefly.. so far, i've found that for anonymous users, the module actions array only contains 2 actions: help and online help (even when print and rss are enabled), hence no other actions can ever be made visible

Erik van Ballegoij, Former DNN Corp. Employee and DNN Expert

DNN Blog | Twitter: @erikvb | LinkedIn: Erik van Ballegoij on LinkedIn

 
New Post
1/5/2007 12:02 PM
 

ok. finished looking into this a bit more than briefly, and found this: line 511 of PortalModuleBase.vb states this:

If ModuleConfiguration.DisplayPrint And CanAddAction(SecurityAccessLevel.Anonymous, True) Then

in DNN 4.3.7 it was this:

If ModuleConfiguration.DisplayPrint

The culprit seems to be function CanAddAction (line 421 of of PortalModuleBase.vb), if True is passed for checkAdminControl, an aditional check is done in line 429:

canAdd = EditMode

this will only evaluate to true if EditMode is true, which will hardly ever be the case for anonymous users, and also hardly ever to non admins. The solution can go two ways: either remove the check on EditMode in CanAddAction, or change line 511 to

AndAlso Not ModuleConfiguration.IsAdmin AndAlso Not IsAdminControl()

If ModuleConfiguration.DisplayPrint And CanAddAction(SecurityAccessLevel.Anonymous, False) Then

(this will still check basic security, but will not check for editMode. I applied the last fix, which seems to work locally for me)

BTW, the same type of issue goes for the RSS feed button, this action is added in line 500. The same fix also works here (change CanAddAction(SecurityAccessLevel.Anonymous, True) to CanAddAction(SecurityAccessLevel.Anonymous, False) )

Funny enough.. when is a fix a fix. It seems DNN finaly works correctly like this, with the possibly unwanted effect that anononymous users will see the solpart actions menu. Also, when the fix for the rss button is applied, the button will be invisible if so selected in the module settings, however, the action is still visible in the action menu.

Charles, could you maybe chime in here?

 

 


Erik van Ballegoij, Former DNN Corp. Employee and DNN Expert

DNN Blog | Twitter: @erikvb | LinkedIn: Erik van Ballegoij on LinkedIn

 
New Post
1/5/2007 12:25 PM
 

Well - I think erik's explanation is substantially correct.

Actions have been reworked over the last couple of releases.  The theory is that it is the actions should be built in PortalModuleBase, which has all the security knowledge and the action menu and action buttons should just show what is available.

In previous versions, the logic to manage was littered all over the app (Skin.vb, PortalModuleBase and even in the ActionsMenu and ActionButton).

In the current behaviour if an item is visible (it should display in the menu and in the button).

I  agree that we may need to tweak this, but the current behaviour fixes quite a large number of wierd behaviour requirements.  For instance, prior to these changes adding an ActionButton to a skin required an ActionMenu in the skin (even if it was not visible).

The logic should be changed to show the Print/RSS buttons, but as discussed above this wil display the Action menu.


Charles Nurse
Chief Architect
Evoq Content Team Lead,
DNN Corp.

Want to contribute to the Platform project? - See here
MVP (ASP.NET) and
ASPInsiders Member
View my profile on LinkedIn
 
New Post
1/5/2007 12:29 PM
 

Thank you Erik and Charles for this info.
I have a site I really need to upgrade and this is a show stopper.

Off to have  try
Thanks
Ian

Later
Where is PortalModuleBase.vb please


Mutate and Survive
 
New Post
1/5/2007 3:45 PM
 

I have my prod site on 4.3.7.
Should I migrate it to 4.4.0 and apply a "fix" (I am not sure that I have understood what to do). Or should I wait 4.4.1 ??? Are there other problems with 4.4.0 ?

DV

 
Previous
 
Next
HomeHomeUsing DNN Platf...Using DNN Platf...Administration ...Administration ...Print Module not showing for unregistered usersPrint Module not showing for unregistered users


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out