Preliminary testing of the DNN_Events_03.03.01_Beta1 resulted in the following:
1) Error during installation:
StartJob Start Sql execution: 03.03.01.SqlDataProvider file
Failure SQL Execution resulted in following Exceptions: System.Data.SqlClient.SqlException: There is already an object named 'DNN_SplitIDs' in the database. at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection) at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException, Boolean breakConnection) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj) at System.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj) at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async) at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery (DbAsyncResult result, String methodName, Boolean sendToPipe) at System.Data.SqlClient.SqlCommand.ExecuteNonQuery() at DotNetNuke.Data.SqlDataProvider.ExecuteADOScript(String SQL) at DotNetNuke.Data.SqlDataProvider.ExecuteScript(String Script, Boolean UseTransactions) CREATE FUNCTION dbo.DNN_SplitIDs ( @RecordIDList varchar(500) ) RETURNS @ParsedList table ( RecordID int ) AS BEGIN DECLARE @RecordID varchar(10), @Pos int SET @RecordIDList = LTRIM(RTRIM(@RecordIDList))+ ',' SET @Pos = CHARINDEX(',', @RecordIDList, 1) IF REPLACE(@RecordIDList, ',', '') <> '' BEGIN WHILE @Pos > 0 BEGIN SET @RecordID = LTRIM(RTRIM(LEFT(@RecordIDList, @Pos - 1))) IF @RecordID <> '' BEGIN INSERT INTO @ParsedList (RecordID) VALUES (CAST(@RecordID AS int)) --Use Appropriate conversion END SET @RecordIDList = RIGHT(@RecordIDList, LEN(@RecordIDList) - @Pos) SET @Pos = CHARINDEX(',', @RecordIDList, 1) END END RETURN END
EndJob End Sql execution: 03.03.01.SqlDataProvider file
No other problems were encountered during install.
2) Following install, module displayed this message:
"Please update module settings...contact Portal Admin."
even though no setting changes were actually necessary. Message went away after updating module settings. This may be desired behavior, but would prefer it to be shown only when administrator/host is logged in. Also rather than hardcoding the text of this message in Events.ascx, it should be localized.
3) Page with EventList view showed same message. However, when clicked on Settings for previously configured module in EventList view, received error:
"A critical error has occurred. Cannot have multiple items selected in a DropDownList."
I traced this back to hardcoding 'Selected="True"' in Settings.ascx in the ddlDefaultView ListItems for Value="Eventmonth.ascx". When I deleted "Selected="True" from the ddlDefaultView control's ListItems, the Settings page opened properly. Rather than hardcoding the default selection in the .ascx's declarative code, selection of the default should be done in the LoadSettings method of Settings.ascx.vb only if ModuleSettings does not already contain a value for "DefaultView". Alternatively, do not specify any of the items as selected in which case, the first item in the list will become the default. Currently, this would be - "List" rather than the more preferable "Month". As the name of the control is stored in ModuleSettings("DefaultView"), I would simply reorder the list items to put "Month" first - should not cause any problems with previously installed module instances.
4) The previously reported problem of Event List Settings not being properly read from ModuleSettings during the LoadSettings method has been corrected. Likewise with the population of the Available and Selected columns of the DualListBox for the Event List Events Fields to Display. Thanks!
5) The previously reported problem of recurring events repeated weekly not being carried over to future months other than the one in which the event was added has now been corrected. Thanks!
6) Although this might be classified as a new feature, which I can well understand you don't want for this version, I would be helpful if the date/time formats of the StartDate and EndDate items could be specified in ModuleSettings rather than hardcoding {0:g} or {0:G} as their format strings, respectively.
7) That's all for now. I'll continue testing and advise of any other problems.