Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeOur CommunityOur CommunityGeneral Discuss...General Discuss...TabInfo.IsAdminTab - No longer valid in DNN 5.0?TabInfo.IsAdminTab - No longer valid in DNN 5.0?
Previous
 
Next
New Post
1/8/2009 1:33 PM
 

Brian, i dont see why. It is a logical result of removing the concept of admin pages. Technically t is not a breaking change

anyhow, check this blog I just wrote, as an example how you can easily make your admin menu accesible to non admins: http://www.erikvanballegoij.com/tabid/36/itemid/22/DotNetNuke-5-Tip-give-non-admins-access-to-any-ad.aspx

 


Erik van Ballegoij, Former DNN Corp. Employee and DNN Expert

DNN Blog | Twitter: @erikvb | LinkedIn: Erik van Ballegoij on LinkedIn

 
New Post
1/8/2009 1:39 PM
 

Marking it as obsolete and leaving it there, but not setting it is a bug.

It's actually a very bad bug because it is invisible.

Take it out completely if it is not going to be set.  That way modules that are using it will break explicitly instead of quietly.


DotNetNuke Modules from Snapsis.com
 
New Post
1/8/2009 2:25 PM
 

I agree with John,  it should either be removed or "fixed".

I personally don't see a problem in fixing it since because it would support DNN 4 modules and skin objects.

I would agree with Erik if the admin modules would respect the userroles in  their behavior, but they don't.

An admin module is an admin module and gives any user that can access it Admin rights for that module, so the discusion about other users accessing the admin pages is theorectical IMO (sorry Erik ;-)

If you giva a "normal" user access to one of the exisitng admin pages this user in effect has the same edit rights as an admin.

Here you have to consider how many people are going to leave the admin menus the way they are and use exising DNN 4 modules / skin objects vs those who do change the admin pages.

IMO that will be at least around 25:1

 
New Post
1/8/2009 3:06 PM
 

Timo,

the strict distinction between "user modules" and admin modules will vanish - e.g. is a Newsletter module an admin module, if target audience can be limited? There might be a benefit of a "Is Admin" Setting for a root page, which can be used by menus to distinct between user menus and administrative ones, but this would be ONLY a feature to separate them in menues, not a logical one. But maybe we need a different option to separate types of menus, imo this needs more brain input before the implementation.

John,

to avoid a *breaking* change, isAdmin should always return false except for the host menu. This will result in admin menu being displayed like ordinary menus, but not to disappear completely.


Cheers from Germany,
Sebastian Leupold

dnnWerk - The DotNetNuke Experts   German Spoken DotNetNuke User Group

Speed up your DNN Websites with TurboDNN
 
New Post
1/8/2009 4:07 PM
 

Timo Breumelhof wrote
 

An admin module is an admin module and gives any user that can access it Admin rights for that module, so the discusion about other users accessing the admin pages is theorectical IMO (sorry Erik ;-)

If you giva a "normal" user access to one of the exisitng admin pages this user in effect has the same edit rights as an admin.

I respectfully disagree with you Timo ... in DNN 5 it is EXPLICITLY possible to give non admin users access to part of the admin menu. Any module checking for "IsAdmin" would hide that page, regardless of actual permissions, which in turn will cause the user to NOT be able to navigate to that page. The issue with the IsAdmin flag is that it doesnt do any permission checking, it only checks based on a location in the menu. This was good when we could safely assume that the only role accessing that page in that menu was the admin role. Since we cannot and should not assume that anymore, the IsAdmin flag should always return False (and let permissions do their work).

Quite frankly, i think this whole discussion is academic. Can someone please give an actual example where a module or skin object behaves differently between dnn 4 and 5 and where this is a major issue.


Erik van Ballegoij, Former DNN Corp. Employee and DNN Expert

DNN Blog | Twitter: @erikvb | LinkedIn: Erik van Ballegoij on LinkedIn

 
Previous
 
Next
HomeHomeOur CommunityOur CommunityGeneral Discuss...General Discuss...TabInfo.IsAdminTab - No longer valid in DNN 5.0?TabInfo.IsAdminTab - No longer valid in DNN 5.0?


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out