John is correct : I raised the thread to get a more complete understanding of the thinking behind the change.  It's wrong to assume developers are going to use the 'IsAdminTab' for security purposes : it's quite clear you should be checking the user permissions for that.  In my case I use the IsAdminTab in the Friendly Url Provider code to not bother generating Friendly Urls for Admin tabs.  Some Admin modules don't like Friendly Urls, and there's no point in using up processing on non-public facing pages for friendly urls.

So, in terms of appearances for modules like menu modules, and other modules, the IsAdmin property was quite useful to determine display type settings.

I'm in two minds : the change is correct (to always display false) because the concept of an Admin tab no longer really exists, but then again, it's incorrect, because an Admin tab is still an Admin tab if it contains functions to do with Administrating the website : it's a boolean set on tab purpose rather than tab security settings, or which use has access.  To me it would probably be useful to be able to set the property explicitly (and default it to true for the core admin tabs).  But that would require a database change, and it probably still wouldn't stop sneaky errors coming in.

I'll just have to come up with some other way of determining admin tabs vs ordinary tabs.  Any solution will be imperfect though : a boolean is the only solid solution.  Oh well :|

[quote] if it starts with //admin it is reasonably safe to assume this is the admin menu[/quote]
It may be just me but I disagree with that. For the business I put sites up for, I often name a tab Administration, as that is where the corporate/managers do their adminstrating; Which if you just checked if it starts with '//admin' would also be true when checking IsAdmin but that obviously shouldn't. It's a very clear word to name the tab
I didn't use Admin solely because of the Admin meny that was default for DNN. Administration is a big word to have in the root meny, I'd love to be able to swap DNN's Admin to be Administration and vice versa for the users. It will shorten the meny and help prevent overflow.

If IsAdminTab returned true if the only permission that had view permission on that tab was the Administrator Role, I think that would be a good use of the IsAdminTab. It's certainly not the same as it was before, but with the modification that took out the Admin menu, I think recylcing the flag to identify a page as being viewable to admins only would be a good use for it. How/When it would be used, I don't know; I have rarely used that (if ever), so I don't think about it much.

That's my 2c for now. :)

I just had some trouble with this. I basically have a dropdown menu which lists all DNN tabs except admin tabs, checking for isAdminTab. Now of course these admin tabs are listed. So what's the best way to exclude them? I'm really not sure what permissions I have to check, and against what.