Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsStoreStoreCurrentCart.csCurrentCart.cs
Previous
 
Next
New Post
8/25/2010 12:31 PM
 
I am curious about some code in CurrentCart.cs and I was wondering if you could explain your logic.

The logic uses a static variable
private static bool _isCartVerified = false; //line 36

Further down in the code, the method getCartID(), uses this _isCartVerified variable to see if it needs to verify thecart is in the database. I thought static varibles have application scope and _isCartVerified  would always be true for all carts after the first cart verification? I don't think this would be an issue for your application and cause errors but it seems to not be correct....

Thanks Chris

// Do we need to verify?

if ((string.IsNullOrEmpty(cartID) == false) && (_isCartVerified == false))

{

    CartController controller = new CartController();

    _isCartVerified = (controller.GetCart(cartID, portalID) != null);

    if (_isCartVerified == false)

    {

        cartID = null;

    }

}



 
New Post
8/25/2010 7:31 PM
 
Hi,

Thanks for the suggestion, I have started to "clean" and to review the code in the next version and I will look at this in a future version.
Please read my signature.

Gilles

We (team members) are Humans offering their knowledge, their work and their spare time FOR FREE to benefit the community. It would be so particularly appreciated that your messages begin with "Hello" and end with "Thank you" or any other form of politeness. Ask yourself what your reaction would be, if you were approached by me (a total stranger) on the street to ask you something without saying "Hello" nor "Thank you"? After several years of services dedicated to the community, I begin to be tired to read requests without any form of politeness.
 
Previous
 
Next
HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsStoreStoreCurrentCart.csCurrentCart.cs


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out