DNN 5.6.7 install and upgrade packages still have a broken stored proc for DeletePortalDesktopModules.  The current stored prod will remove ALL assigned modules if you remove ANY module from ANY portal (either Premium or not) due to missing criteria in the stored proc.

I posted a fix in Gemini and on these forums in December 2011, but no change was made in the 5.6.7 package released in Feb 2012.

The stored proc in DNN 6 works, as does the following (the bolded text indicate the changes to the proc in 5.6.7):

set QUOTED_IDENTIFIER ON
GO

... ALTER PROCEDURE [dbo].[DeletePortalDesktopModules]
@PortalID int,
@DesktopModuleId int
AS
BEGIN
IF @PortalID is not null AND @DesktopModuleId is not null
DELETE FROM dbo.PortalDesktopModules WHERE PortalId = @PortalID AND DesktopModuleId = @DesktopModuleId
IF @PortalID is not null AND @DesktopModuleId is null
DELETE FROM dbo.PortalDesktopModules WHERE PortalId = @PortalID
IF @DesktopModuleId is not null AND @PortalID is null
DELETE FROM dbo.PortalDesktopModules WHERE DesktopModuleId = @DesktopModuleId
END

Ken,

I'm aware that the issue has been resolved in DNN6.

I'm asking if it can be fixed in DNN 5.  I reported the bug AND one possible solution a couple of months before the most recent DNN 5x release.

Mike;

We are about to release the final 5.6.x packages this month.

Our "sunset" or "end of life" policy for 5.x is July 20, 2012 as stated in Shaun Walker's blog posting here:http://www.dotnetnuke.com/Resources/B...

As such, we will not be fixing this issue for 5.6.x.