I posted this in the documents forum and was told to put it here, since the control is a core object.

Many users of my sites are having confusion around the file picker/upload control in the documents module.  This is a suggestion to improve the usability of the control by fixing what I consider a bug.

Here's what the users do:  They want to upload a new file, so they click the Upload New File link, then Browse... and they pick the file they want.  Problem is, they never click the Upload Selected File link.

Having to click Upload Selected File is not intuitive so people miss this step.  When they miss it, one of 2 problems ocurrs:  The document is simply linked to the first document in the list, which is wrong, or it somehow is linked to a bad file ID. 

It seems this is a bug to allow the user to browse for a new file, then accept the Update link without forcing them to either upload the file or choose an existing one. 

SUGGESTION:  If the user chooses a new file, just upload it automatically when they click Update.  Don't make them click Upload Selected File.  You could leave it as an option, but don't require it.