I've had great success creating a user with DNN's UserController but I cannot seem to get it to add the user to a role on create. I don't get an error either. Most of the user and role threads I have found appear to be obsolete. 

Anyone know something I don't?

        private UserInfo GenerateUserInfo(WholesaleClient client)

        {

            var userInfo = new UserInfo();

            userInfo.Username = client.Username;

            //set role - not working

            userInfo.Roles = new string[] { "Wholesale User" }; 

            //set auto generated password

            userInfo.Membership.Password = membershipProvider.GeneratePassword();

            userInfo.Email = client.Email;

            userInfo.FirstName = client.FirstName;

            userInfo.LastName = client.LastName;

            userInfo.Username = client.Username;

            userInfo.DisplayName = client.BusinessName;

            userInfo.PortalID = 0;        

            return userInfo;

        }

Thanks Cathal. I did come across that but I'm not very familiar with VB, however, looking at it again I  am able to surmise that it first creates the user, then grabs the userID which is used to add the user to the role if the user creation was successful. I'll try it out... hopefully I can adapt that in C# and the way I have to implement this.  

I don't mean to be a pain but I really hope DNN improves on their API documentation...the most recent only displays the namespaces, no examples. DNN is a great framework from what I have seen but where is MVC, RECENT module development tutorials and ORM support? In terms of Visual Studio templates I've only found very old extensions. Being, albeit extended, family of Microsoft I would have thought DNN development would be a lot smoother and perhaps with even more best practice orientated methodologies. Hope to see that change. 

Came right with this:

AddRole method:

public bool addRoleToUser(UserInfo user, string roleName, DateTime expiry)

        {

       bool rc = false;

       RoleInfo newRole = roleController.GetRoleByName(user.PortalID, roleName);

       if (newRole != null && user != null)

       {

       rc = user.IsInRole(roleName);

                roleController.AddUserRole(user.PortalID, user.UserID, newRole.RoleID, DateTime.MinValue, expiry);

       user = UserController.GetUserById(user.PortalID, user.UserID);

       rc = user.IsInRole(roleName);

       }

       return rc;

        }

Create user and add to role:

private void ApproveFor(WholesaleClient client)

        {

            client.IsVerified = true;

            var userInfo = GenerateUserInfo(client);

            var createStatus = membershipProvider.CreateUser(ref userInfo);

            if (createStatus == UserCreateStatus.InvalidPassword)

                throw new Exception("Invalid password");

            //save back to table with IsVerified set

            if (createStatus == UserCreateStatus.Success)

            {

                var roleName = "Wholesale Client";

                addRoleToUser(userInfo, roleName, DateTime.MaxValue);

                clientRepository.Update(client);

                return;   

            }

            throw new Exception("Error occurred");

        }