We have implemented an alternal login to our custom specific DNN solution using electronic certificates which works fine. Now we want to utilize that in an API based on the DNN Service Framework and using JWT tokens so that after a successful authentication with electronic ids, we will call the class and have that issue the necessary token.

However, to our surprise we noted that for some reason, the JwtController is marked as internal, meaning that this wont work (AFAIK), ie it can only be accessible using REST calls to the DNN Service Layer.

internal class JwtController : ServiceLocator, IJwtController

Whats the reason for this? Is there a thought to it or just a mistake? I can't see any obvious advantatges of it, and several disadvantages. The other authentication controllers in the Core seem to all be public.

We changed that to "public" locally and just built that DLL and replaced the normal Dnn.AuthServices.Jwt.dll and that seems to work fine, but for obvious reason, having customized version of the core is not good.

Is there a reason to this or should we just create a PullRequest for it to change?

https://github.com/dnnsoftware/Dnn.Platform/commits/development/DNN%20Platform/Dnn.AuthServices.Jwt/Components/Common/Controllers/JwtController.cs