Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsUsers OnlineUsers OnlineGetOnlineUsers StoredProcGetOnlineUsers StoredProc
Previous
 
Next
New Post
5/3/2007 11:04 AM
 

I am puzzled by the GetOnlineUsers() stored procedure. Looking at the 3 scripts in various versions (3.02.03, 4.00.04 and 4.03.04), It seems to have received and removed some 'show me less and specified field' optimalisation. Anybody a suggestion?

>> From 03.02.03 SqlDataProvider. -----------------------------------------------------------------
/* Add Get Online Users Stored Procedures */
/******************************************/

if exists (select * from dbo.sysobjects where id = object_id(N'{databaseOwner}{objectQualifier}[GetOnlineUsers]') and OBJECTPROPERTY(id, N'IsProcedure') = 1)
 drop procedure {databaseOwner}{objectQualifier}GetOnlineUsers
GO

CREATE PROCEDURE {databaseOwner}{objectQualifier}GetOnlineUsers @PortalID int

AS

SELECT
 UO.UserID,
 U.Username
 FROM {objectQualifier}UsersOnline UO
  INNER JOIN {objectQualifier}Users U ON UO.UserID = U.UserID
  INNER JOIN {objectQualifier}UserPortals UP ON U.UserID = UP.UserId
 WHERE  UP.PortalID = @PortalID
 
GO

>> From 04.00.04 SqlDataProvider. -----------------------------------------------------------------

/* Add Get Online Users Stored Procedures */
/******************************************/

if exists (select * from dbo.sysobjects where id = object_id(N'{databaseOwner}[{objectQualifier}GetOnlineUsers]') and OBJECTPROPERTY(id, N'IsProcedure') = 1)
 drop procedure {databaseOwner}[{objectQualifier}GetOnlineUsers]
GO

CREATE PROCEDURE {databaseOwner}[{objectQualifier}GetOnlineUsers]
 @PortalID int

AS

SELECT
 UO.UserID,
 U.Username
 FROM {objectQualifier}UsersOnline UO
  INNER JOIN {objectQualifier}Users U ON UO.UserID = U.UserID
  INNER JOIN {objectQualifier}UserPortals UP ON U.UserID = UP.UserId
 WHERE  UP.PortalID = @PortalID
 
GO

>> From 04.03.04 SqlDataProvider. -----------------------------------------------------------------

/* Update GetPropertyDefinitionsByCategory */
/*******************************************/

IF EXISTS ( SELECT * FROM sysobjects WHERE id = object_id(N'{databaseOwner}{objectQualifier}GetOnlineUsers') AND OBJECTPROPERTY(id, N'IsProcedure') = 1)
 DROP PROCEDURE {databaseOwner}{objectQualifier}GetOnlineUsers
GO

CREATE PROCEDURE {databaseOwner}{objectQualifier}GetOnlineUsers
 @PortalID int

AS
SELECT
 *
 FROM {objectQualifier}UsersOnline UO
  INNER JOIN {objectQualifier}vw_Users U ON UO.UserID = U.UserID
  INNER JOIN {objectQualifier}UserPortals UP ON U.UserID = UP.UserId
 WHERE  UP.PortalID = @PortalID
GO


XCESS expertise center b.v.
Regards,
Ernst Peter
LinkedIn Profile Ernst Peter Tamminga


XCESS: DNN/Evoq specialist, zie www.xcess.nl

Events 7.0.1 - Released
Reports 6.1.0 - Released
 
New Post
5/4/2007 9:58 AM
 

That is a very interesting observation, I cannot think of any reason why a SELECT * would be done here as that is grabbing all fields from all tables...and that is just not needed...

 


-Mitchel Sellers
Microsoft MVP, ASPInsider, DNN MVP
CEO/Director of Development - IowaComputerGurus Inc.
LinkedIn Profile

Visit mitchelsellers.com for my mostly DNN Blog and support forum.

Visit IowaComputerGurus.com for free DNN Modules, DNN Performance Tips, DNN Consulting Quotes, and DNN Technical Support Services
 
Previous
 
Next
HomeHomeDNN Open Source...DNN Open Source...Module ForumsModule ForumsUsers OnlineUsers OnlineGetOnlineUsers StoredProcGetOnlineUsers StoredProc


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out