Ok, there is something definitely wrong now.  I did a complete remove and then re-install (see my previous post) and everything was working.  Now today, I get the error message, even when logged in as administrator.  I even did an IISRESET.

If I login with an account that is not listed in the download permissions, the download link is not visible.  Logged in with an account that does have permissions and the download link show up but I get that error message on a plain blank page.

Is the source code available, the If statement that executes when you click "Download" no worky :)

http://www.flashpointracing.com/Garage/Showroom/tabid/124/Default.aspx

Thanks, and we split off from OLR, their web site was all custom built ASP and C++, it was way to difficult to get stuff done.  Another DNN site, nice, that's 3 simracing sites I know of so far that us it.

I found the problem and I'm pretty sure this would be considered a 'bug'

I left a lot of the settings on the Repository as the default.  In this case, having the 'unapproved' and 'approved' folders being the same was a bad thing.  I think the following logic in the repository has a flaw in it.

-User uploads file, it's stored in the unapproved folder
-Admin approves the upload.
   + File is copied from the unapproved to approved folder (in my case, this really just copies the file over itself)
   + File is deleted from the unapproved folder (take a guess what happens :)

The error message obviously doesn't properly describe the problem.

I don't think there's an error in the logic. When you approve a file, it first determines where the unapproved file is, then where the approved file would go once approved. It only goes through the copy/delete logic if the current location is not the same as the new location. If the new location would be the same, then the file will just remain where it is and marked as approved.

Here's the actual code... with the relevant code in red

Try
  strSourceFilename = objRepositoryBL.g_UnApprovedFolder & "\" & objRepository.FileName.ToString()
  If objRepository.CreatedByUser = "" Then
    strTargetFilename = objRepositoryBL.g_AnonymousFolder & "\" & objRepository.FileName.ToString()
  Else
    If objRepositoryBL.g_UserFolders Then
      If Not Directory.Exists(objrepositorybl.g_ApprovedFolder & "\" & objRepository.CreatedByUser()) Then
        Directory.CreateDirectory(objrepositorybl.g_ApprovedFolder & "\" & objRepository.CreatedByUser())
      End If
      strTargetFilename = objRepositoryBL.g_ApprovedFolder & "\" & objRepository.CreatedByUser() & "\" & objRepository.FileName.ToString()
    Else
      strTargetFilename = objRepositoryBL.g_ApprovedFolder & "\" & objRepository.FileName.ToString()
    End If
  End If
  If strSourceFilename <> strTargetFilename Then
    File.Copy(strSourceFilename, strTargetFilename, True)
    File.SetAttributes(strSourceFilename, FileAttributes.Normal)
    File.Delete(strSourceFilename)
    bMovedFile = True
  End If
Catch ex As Exception
End Try