I haven't tested the module on 4.0.2 or greater, but theoretically it should work and apparently it does not. Because of this, I am not sure exactly what the issue is. If the only problem appears to be email notification then the problem is probably how I had to change the forums to work with the new Membership/Profile API that was part of 3.3/4.3. This means in the ForumUser object you would have to change the source so it gets the email differently.

As for your upgrade, there are a number of reasons this could have gone wrong. I haven't had any issues upgrading 4.0.2 to 4.3.x, but in fairness I have been doing this for a few years. What did you use for upgrade, Install, Source or Upgrade version? You aren't using the Starter Kit by chance are you?

First, it should not try to re-create a portal that is there and that is why the upgrade ultmiately failed. What this means is you probably need to review the databaseOwner and objectQualifier items in the web.config set towards the bottom. Make sure in the new they match the old. To me, it seems it installed a new portal and tried to create the portals\0 directory but it already existed and it failed. This means your entire DB should have had two sets of each sproc and table.

I advise trying the upgrade again. There are some serious issues in 3.20.06 which are corrcted in 3.20.08.

I got the upgrade done and upgraded to the latest forum module.  When I first created the different forums on my site I was able to get to my settings as admin.  After I did a test post as another user, I still didn't receive a moderation email even though the notification was checked and the email address was correct.  Now I can't get to my Settings.  I am getting the following errors.

ModuleId: 523
ModuleDefId: 128
FriendlyName: User Settings
ModuleControlSource: DesktopModules/Forum/Forum_UserSettings.ascx
AssemblyVersion: 04.03.03
PortalID: 2
PortalName: Downtown Revitalization
UserID: 3
UserName: smbenson
ActiveTabID: 125
ActiveTabName: Forum
RawURL: /downtown/Forum/tabid/125/ctl/UserSettings/mid/523/userid/3/Default.aspx
AbsoluteURL: /Default.aspx
AbsoluteURLReferrer: http://www.staplesmn.info/downtown/Forum/tabid/125/ctl/usermanage/mid/523/Default.aspx
UserAgent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 2.0.50727)
DefaultDataProvider: DotNetNuke.Data.SqlDataProvider, DotNetNuke.SqlDataProvider
ExceptionGUID: 55489025-c00d-4ff7-8c27-ed5e503716b8
InnerException: Object reference not set to an instance of an object.
FileName:
FileLineNumber: 0
FileColumnNumber: 0
Method: DotNetNuke.Modules.Forum.UserSettings.SelectMultiTreeItems
StackTrace:
Message: DotNetNuke.Services.Exceptions.ModuleLoadException: Object reference not set to an instance of an object. ---> System.NullReferenceException: Object reference not set to an instance of an object. at DotNetNuke.Modules.Forum.UserSettings.SelectMultiTreeItems(DnnTree objTree, Int32 ForumID) at DotNetNuke.Modules.Forum.UserSettings.Page_Load(Object sender, EventArgs e) --- End of inner exception stack trace ---

It seems that I am still having the same problems with the new version.  Any help to make this work would be appreciated.

Thanks.