Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeArchived Discus...Archived Discus...Developing Under Previous Versions of .NETDeveloping Under Previous Versions of .NETASP.Net 2.0ASP.Net 2.0NavigateURL FriendlyURLs UrlEncore 4.7 breaking change?NavigateURL FriendlyURLs UrlEncore 4.7 breaking change?
Previous
 
Next
New Post
11/17/2007 1:13 AM
 

I am looking into the NavigateURL method and am wondering if a resent change to DNN 4.7 is causes a breaking change.  In particular the file  FriendlyURLProvider.vb was changed near the bottom from:

pathToAppend = pathToAppend & "/" & System.Web.HttpUtility.UrlEncode((Chr(32)).ToString())                   to:
pathToAppend = pathToAppend & "/" & System.Web.HttpUtility.UrlPathEncode((Chr(32)).ToString())

The difference being the UrlEncode() replaced with UrlPathEncode()

This code is used when a parameter on the query string is blank.  The old UrlEncode turned the blank querystring parameter to a "+", while the new UrlPathEncode translates it to a "%20".  So in the URL it appears as  http://stuffstuffstuff/param1/%20/param2/abc/default.aspx  It appears that with a "%20" in the querystring (between to /'s) the request never even makes it into the DNN rewriter module and the user gets a page not found error.

My solution to this is to make sure that everything I put on a querystring is non-blank (at least a " "), but just wondering why this changed?

 
New Post
11/17/2007 10:46 PM
 

Hey james,

Interesting catch in the core code - I wonder how many modules this will break.

Technically URLPathEncode is doing the correct thing - and URLEncode is doing the wrong thing.
In reality the + sign is actually a valid path value.

This is actually a reasonably old and documented issue in URLEncode - but sadly one that MS have
never fixed because doing so would break too many sites.

As to how to deal with it...

Thats a more difficult issue for the CORE team.

Westa

 
Previous
 
Next
HomeHomeArchived Discus...Archived Discus...Developing Under Previous Versions of .NETDeveloping Under Previous Versions of .NETASP.Net 2.0ASP.Net 2.0NavigateURL FriendlyURLs UrlEncore 4.7 breaking change?NavigateURL FriendlyURLs UrlEncore 4.7 breaking change?


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out