Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeArchived Discus...Archived Discus...Developing Under Previous Versions of .NETDeveloping Under Previous Versions of .NETASP.Net 2.0ASP.Net 2.0Functionality of GetModuleByDefinition has been changed in 4.04Functionality of GetModuleByDefinition has been changed in 4.04
Previous
 
Next
New Post
1/2/2007 7:15 PM
 

I found that in 4.04 stored procedure  GetModuleByDefinition  has been changed.

In 4.0.3 it  searched by dnn_ModuleDefinitions.FriendlyName, and now it searches by dnn_DesktopModules..FriendlyName( DM.FriendlyName in dnn_vw_Modules view).
It is certarnly
 a breaking change, because fields can have different values.
Please advice, is it intentional? 
If yes,  data conversion scripts are required.
If it is a bug, dnn_GetModuleByDefinition   SP should be changed back to filter by dnn_ModuleDefinitions.FriendlyName.
(Update: I've decided that it is  a bug and raised a Gemini issue)

For backward compatibility I've changed the SP as following:

ALTER PROCEDURE [dbo].[dnn_GetModuleByDefinition]
 
      @PortalId int,
      @FriendlyName nvarchar(128)
     
AS

SELECT {objectQualifier}vw_Modules.*

FROM {objectQualifier}vw_Modules

INNER JOIN

{objectQualifier}ModuleDefinitions as MD ON {objectQualifier}vw_Modules.ModuleDefID = MD.ModuleDefID

WHERE ((PortalId = @PortalId) or (PortalId is null and @PortalID is null))

AND MD.FriendlyName = @FriendlyName

AND IsDeleted = 0


Michael Freidgeim http://geekswithblogs.net/mnf
 
New Post
1/19/2007 5:51 AM
 
Aah - genius!

I upgraded PokerDIY.com to DNN 4.4.0 and all my module integrations started breaking. I narrowed it down to
"ModuleInfo privateMessagingModuleInfo = moduleController.GetModuleByDefinition(currentPortalID, "DnnForge - PrivateMessages");"

(so you can send messages to Smart-Thinker Group Users with Ventrian's PM module).

This is absolutely major I think as it basically caused most of my Smart-Thinker modules to fallover. Luckily most of them have integration settings so the damage can be limited, but this needs to be made fixed ASAP please.

Roll on 4.4.1 (is this change definitely confirmed?)

Entrepreneur

PokerDIY Tournament Manager - PokerDIY Tournament Manager<
PokerDIY Game Finder - Mobile Apps powered by DNN
PokerDIY - Connecting Poker Players

 
Previous
 
Next
HomeHomeArchived Discus...Archived Discus...Developing Under Previous Versions of .NETDeveloping Under Previous Versions of .NETASP.Net 2.0ASP.Net 2.0Functionality of GetModuleByDefinition has been changed in 4.04Functionality of GetModuleByDefinition has been changed in 4.04


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out