Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeOur CommunityOur CommunityGeneral Discuss...General Discuss...Bug in banner module - missing closing tagBug in banner module - missing closing tag
Previous
 
Next
New Post
7/3/2007 11:09 AM
 

I tried to add to the case tool (Gemini), but there is no room for banner module. So I post it here in the hope somebody picks it up:

http://support.dotnetnuke.com/issue/ViewIssue.aspx?id=5873

Problem:
The banner module rendering of image does not close the image tag. As a result the skin and modules on the page are not aligned nicely.

Cause/ Solution:
Could you please add a closing tag in the image so that alignment is oke?

From my developer:
====
I disassemble DotNetNuke.dll, and found that the Banners Moudle of dnn render img tags without end tag, this is the code :
    StringBuilder builder = new StringBuilder();
    builder.Append("<img src=\"" + File + "\" border=\"0\"");
    if (Operators.CompareString(Description, "", false) != 0)
    {
        builder.Append(" alt=\"" + Description + "\"");
    }
    else
    {
        builder.Append(" alt=\"" + BannerName + "\"");
    }
    if (Width > 0)
    {
        builder.Append(" width=\"" + Width.ToString() + "\"");
    }
    if (Height > 0)
    {
        builder.Append(" height=\"" + Height.ToString() + "\"");
    }
    builder.Append(">");
    return builder.ToString();

I don't know this can be modified, it is in DotNetNuke.dll. Will we copy the code out and make new module?

 

 
New Post
7/3/2007 11:16 AM
 

Jesse,

Banner, User Accounts, Search and all Admin/Host modules are part of the core framework and please enter issues for all of them into the public issue tracker.

Source version of dotnetnuke contains the source code for this, you need to recompile after making changes.


Cheers from Germany,
Sebastian Leupold

dnnWerk - The DotNetNuke Experts   German Spoken DotNetNuke User Group

Speed up your DNN Websites with TurboDNN
 
New Post
11/2/2007 5:06 PM
 

Hi,

The issue had been created and last week I got some notification it would be fixed in next release: so I guess that must be version after 4.6.2.

J.

 
Previous
 
Next
HomeHomeOur CommunityOur CommunityGeneral Discuss...General Discuss...Bug in banner module - missing closing tagBug in banner module - missing closing tag


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out