Products

Solutions

Resources

Partners

Community

Blog

About

QA

Ideas Test

New Community Website

Ordinarily, you'd be at the right spot, but we've recently launched a brand new community website... For the community, by the community.

Yay... Take Me to the Community!

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDevelopment and...Development and...Open Core Testi...Open Core Testi...Still issues with deprecated FileSystemUtils methods in DNN 6.0 BetaStill issues with deprecated FileSystemUtils methods in DNN 6.0 Beta
Previous
 
Next
New Post
6/23/2011 12:02 AM
 
Although the DNN Gallery module v 4.04.00 which is still undergoing testing in the Release Tracker will now install and can be placed on a page without error in DNN 6.0 Beta (thanks to correction to deprecated FileSystemUtils.AddFolder methods), there are still major issues with the AddFolder and other FileSystemUtils methods that prevent Gallery from adding its _thumbs folder and registering it in the Folders table of the DNN database. No errors are being logged, unfortunately.

I'll try to find time tomorrow to do an install of the source version of Gallery 4.04.00 in a DNN 6.0 Beta source and set some breakpoints to find where the failures are occuring. There is also an unrelated issue with failure to generate a Linkclick url from a FileID as used in Gallery's download function.

If any developers have modules which make use of the now deprecated FileSystemUtils methods, particularly those related to adding folders, please be sure to test your modules against the DNN 6.0 Beta as soon as possible.

Bill, WESNet Designs
Team Lead - DotNetNuke Gallery Module Project (Not Actively Being Developed)
Extensions Forge Projects . . .
Current: UserExport, ContentDeJour, ePrayer, DNN NewsTicker, By Invitation
Coming Soon: FRBO-For Rent By Owner
 
New Post
6/23/2011 12:07 PM
 

Here's an update:

In DNN 6.0 Beta 1, the following deprecated method (found in namespace DotNetNuke.Common.Utilities.FileSystemUtils):

public static void AddFolder(PortalSettings portalSettings, string parentFolder, string newFolder, int storageLocation, Guid uniqueId)

ignores the parentFolder parameter completely resulting in the addition of the new folder as a child of the portal home directory rather than the desired parent.

In CTP2, this method included the following line:

var folderPath = PathUtils.Instance.GetRelativePath(folderMapping.PortalID, parentFolder + newFolder);

In Beta 1, this was changed to:

var folderPath = newFolder;

in order to fix Gemini Issue DNN-15928 in which addition of a new folder would always throw an exception since the GetRelativePath method included a check if the physical folder already existed and intentionally thew a new exception if it did not.

I think the following change (line 429 of Library\Common\Utilities\FileSystemUtils.cs) would address the issue but protective coding should also be added should either parentFolder or newFolder params not end with the required forward slash or otherwise be mis-formatted:

var folderPath = parentFolder + newFolder;

I'll either create a new Gemini issue or ask that DNN-15928 be reopened after testing the modification.

The LinkClick issue is not due to failure to generate the correct LinkClick url from a FileID but rather in a change in the behavior of the LinkClickHandler (FileServerHandler) which will now attempt open any file in a new window following a redirect to the actual file url even if the ForceDownload parameter is set to true. I'll investigate this issue further.


Bill, WESNet Designs
Team Lead - DotNetNuke Gallery Module Project (Not Actively Being Developed)
Extensions Forge Projects . . .
Current: UserExport, ContentDeJour, ePrayer, DNN NewsTicker, By Invitation
Coming Soon: FRBO-For Rent By Owner
 
New Post
6/23/2011 1:23 PM
 
William, I'll take care of this. I think the solution is

var folderPath = PathUtils.Instance.GetRelativePath(folderMapping.PortalID, parentFolder) + newFolder;

which is different from the original code in just the place of the parenthesis:

var folderPath = PathUtils.Instance.GetRelativePath(folderMapping.PortalID, parentFolder + newFolder);

Regards
 
New Post
6/23/2011 3:32 PM
 
Ruben,

That should work and as the physical parentFolder must already exist it would make sense for GetRelativePath to intentionally throw an exception if it does not. I'll make that change in my DNN 6 Beta1 source install and do some further testing.

Bill, WESNet Designs
Team Lead - DotNetNuke Gallery Module Project (Not Actively Being Developed)
Extensions Forge Projects . . .
Current: UserExport, ContentDeJour, ePrayer, DNN NewsTicker, By Invitation
Coming Soon: FRBO-For Rent By Owner
 
New Post
6/23/2011 10:53 PM
 
Ruben,

With your suggested change to FileSystemUtils.AddFolder, all is well with Gallery 4.4.0 and DNN 6.0. I also noted that you re-opened Gemini issue DNN-15928 and checked in this modification. Thanks again.

In our Core Team chat today we decided that the change in LinkClick behavior was not intended so I have created Gemini issue DNN-16723 to address it.

Bill, WESNet Designs
Team Lead - DotNetNuke Gallery Module Project (Not Actively Being Developed)
Extensions Forge Projects . . .
Current: UserExport, ContentDeJour, ePrayer, DNN NewsTicker, By Invitation
Coming Soon: FRBO-For Rent By Owner
 
Previous
 
Next
HomeHomeDevelopment and...Development and...Open Core Testi...Open Core Testi...Still issues with deprecated FileSystemUtils methods in DNN 6.0 BetaStill issues with deprecated FileSystemUtils methods in DNN 6.0 Beta


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out