We were testing the upgrade from 5.0.1 to 5.1.0 and came across this error.   It was triggered because the primary key index is PK_EventLog not PK_EventLogMaster in our installation.  The following is from the 05.01.00.log:

System.Data.SqlClient.SqlException: Table 'EventLog' already has a primary key defined on it.
Could not create constraint. See previous errors.
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection)
   at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj)
   at System.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj)
   at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(DbAsyncResult result, String methodName, Boolean sendToPipe)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at DotNetNuke.Data.SqlDataProvider.ExecuteADOScript(String SQL)
   at DotNetNuke.Data.SqlDataProvider.ExecuteScript(String Script, Boolean UseTransactions)

/* Change primary key of EventLog Table */
/****************************************/

IF NOT EXISTS (SELECT 1 FROM INformATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 'dbo.EventLog' AND COLUMN_NAME = 'LogEventID')
 BEGIN
  --Note this name does NOT have an object qualifier in 4.x upgrades
  IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = object_id(N'PK_EventLogMaster'))
   ALTER TABLE dbo.EventLog
    DROP CONSTRAINT PK_EventLogMaster

  --Note this name does have an object qualifier in 5.x installs
  IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = object_id(N'PK_EventLogMaster'))
   ALTER TABLE dbo.EventLog
    DROP CONSTRAINT PK_EventLogMaster

  ALTER TABLE dbo.EventLog
   ADD LogEventID bigint NOT NULL IDENTITY (1, 1)
   
  ALTER TABLE dbo.EventLog
   ADD CONSTRAINT PK_EventLogMaster PRIMARY KEY CLUSTERED ( LogEventID )  
 END

We have already edited the script and will restore the test site from our backup and retry the upgrade.   However, we felt this issue needed to be shared with others.

Mike

You are the expert but I'm not sure I agree with you.  The outcome of the upgrade on our test sites, which are a copies of the production sites, was something I would not put into production.  There is an error on the Home page that we have not been able to figure out yet, the dates at the bottom of the page in module 'Settings' are 01/01/0001, the bottom of the Control Panel is obscured for some reason and there seems to be other issues that, at this moment, I can't describe exactly.  Of course, I don't know if all of these issues relate to this error.  We have 3 different websites in production with 5.0.1 using skins from two different publishers and of two different ages but so far the problems appear to be identical on all three test sites.  As I said, your the expert but we believe we've fixed the ObjectQualifier and the Provider so we'll see what happens with the retest.

Thanks for your attention.

Mike

Thanks a bunch!  That was helpful.  We'll give that a try before we run the retest and see what happens.

Thanks again,

Mike